Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Auto trigger even if pre-cd fails #6338

Merged
merged 5 commits into from
Jan 31, 2025
Merged

fix: Auto trigger even if pre-cd fails #6338

merged 5 commits into from
Jan 31, 2025

Conversation

ayu-devtron
Copy link
Contributor

@ayu-devtron ayu-devtron commented Jan 29, 2025 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1852

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Ash-exp
Ash-exp previously requested changes Jan 29, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ayu-devtron ayu-devtron changed the title fix: add flag to identify if success event fix: Auto trigger even if pre-cd fails Jan 31, 2025
@ayu-devtron ayu-devtron merged commit fc01f62 into main Jan 31, 2025
11 checks passed
@ayu-devtron ayu-devtron deleted the pre-cd-fix branch January 31, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@Ash-exp Ash-exp Ash-exp left review comments

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayu-devtron @Ash-exp @vikramdevtron