Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: devtron apps deployed via helm showing in helm apps list #6397

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: devtron apps deployed via helm showing in helm apps list #6397

merged 1 commit into from
Feb 14, 2025

Conversation

abhibhaw
Copy link
Member

@abhibhaw abhibhaw commented Feb 13, 2025 •
edited
Loading

Description

Fixes #6353

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@github-actions GitHub Actions
Copy link

PR is not linked to a valid issue. Please update the issue link.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@abhibhaw abhibhaw merged commit efb8fe6 into main Feb 14, 2025
10 of 11 checks passed
@abhibhaw abhibhaw deleted the d-6353 branch February 14, 2025 10:41
@abhibhaw abhibhaw mentioned this pull request Feb 14, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Devtron Apps deployed via CI/CD are listed as Helm Apps too.
2 participants
@abhibhaw @vikramdevtron