Added Held Slot handler #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CiviledCode
commented
Feb 20, 2022
CiviledCode
commented
- Removed session.UpdateHeldSlot
- Added player.SetHeldSlot
- Added HeldSlotChange to handler
- Removed session.UpdateHeldSlot - Added player.SetHeldSlot - Added HeldSlotChange to handler
T14Raptor
requested changes
Mar 28, 2022
| // is the correct item. | ||
| // This invokes the HandleHeldSlotChange handler. | ||
| func (p *Player) SetHeldSlot(slot int, expected item.Stack) error { | ||
| if slot > 8 { |
There was a problem hiding this comment.
Why'd you remove all the documentation for this method?
| actual, _ := p.inv.Item(slot) | ||
|
|
||
| if !clientSideItem.Equal(actual) { | ||
| return fmt.Errorf("client side item isn't equal to expected slot item") |
There was a problem hiding this comment.
This code no longer belongs here now that it's a player method, should be moved to packet handling (check a0bb8dd).
| return nil | ||
| } | ||
|
|
||
| p.ReleaseItem() |
There was a problem hiding this comment.
Should just set (Player).usingItem to false here.
| // SetHeldSlot updates the held slot of the player with the slot passed. It also verifies that the item within the spot | ||
| // is the correct item. | ||
| // This invokes the HandleHeldSlotChange handler. | ||
| func (p *Player) SetHeldSlot(slot int, expected item.Stack) error { |
There was a problem hiding this comment.
Passing an expected item stack no longer makes sense here, should be removed.
| @@ -367,6 +368,37 @@ func (p *Player) Transfer(address string) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| // SetHeldSlot updates the held slot of the player with the slot passed. It also verifies that the item within the spot | |||
There was a problem hiding this comment.
Should remove the middle sentence in this doc.
JustTalDevelops
added
feature
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.