Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nice UI for the dummy Relying Party #24

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Add a nice UI for the dummy Relying Party #24

merged 10 commits into from
Jun 7, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Jun 7, 2024

Motivation

Main motivation is to deploy the dummy relying party to mainnet so that developers can get a grasp of the feature fast.

The idea is to link the RP in the dev docs for discoverability.

Changes

  • Add mainnet network to dfx.json.
  • Bumped the II version used.
  • Install tailwind to dummy-relying-party and use it in index.html to build a nice UI.
  • Change the dom manipulation of the JS file to be adapted to the new UI and offer a nice UX.

Tests

Relying party can be test here: https://l7rua-raaaa-aaaap-ahh6a-cai.icp0.io/

Todos

  • Add entry to changelog (if necessary). Not necessary. No new functionality is added to the SDK.

@lmuntaner lmuntaner changed the title Lm nice rp UI Add a nice UI for the dummy Relying Party Jun 7, 2024
@lmuntaner
Copy link
Collaborator Author

For testing purposes:

https://l7rua-raaaa-aaaap-ahh6a-cai.icp0.io/

For example, you can try:

Or:

@lmuntaner lmuntaner marked this pull request as ready for review June 7, 2024 13:01
@lmuntaner
Copy link
Collaborator Author

lmuntaner commented Jun 7, 2024

@frederikrothenberger ready for review

Any feedback from the team can be addressed in separate PRs.

Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and it worked great! Thanks a lot.

@lmuntaner lmuntaner merged commit fe35907 into main Jun 7, 2024
7 checks passed
@lmuntaner lmuntaner deleted the lm-nice-rp-ui branch June 7, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants