Add network-tests flag to toggle tests which require internet
#2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hololeap
force-pushed
the
fix_without_http_tests
branch
from
65426df to
6e9b65f
Compare
Gabriella439
approved these changes
Feb 13, 2022
hololeap
force-pushed
the
fix_without_http_tests
branch
from
fe7a58c to
a1427e8
Compare
hololeap
force-pushed
the
fix_without_http_tests
branch
from
a7ceb49 to
1de76ad
Compare
|
I'm abandoning getting cabal-doctest working. It's a nice workaround for our purposes, but it's simple enough to patch it downstream, or better yet we should get around to tightening down our sandbox. @Gabriel439, take a look at the changes that remain. Sorry for the delay getting back to this. |
There was a problem hiding this comment.
You'll also need to fix warnings for the CI build to pass. See: https://hydra.dhall-lang.org/build/102162
hololeap
changed the title
network-tests flag to toggle tests which require internet
|
@Gabriel439, it seems like the warnings are originating from the |
Allows for disabling network-dependent tests independently of the `with-http` flag.
hololeap
force-pushed
the
fix_without_http_tests
branch
from
a18e744 to
8959873
Compare
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
|
Thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extra stuff that would help tests run with Gentoo's network-disabled sandbox and system-installed Haskell packages.