-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network-tests
flag to toggle tests which require internet
#2383
Add network-tests
flag to toggle tests which require internet
#2383
Conversation
65426df
to
6e9b65f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! I'm ready to merge whenever this is done
fe7a58c
to
a1427e8
Compare
a7ceb49
to
1de76ad
Compare
I'm abandoning getting cabal-doctest working. It's a nice workaround for our purposes, but it's simple enough to patch it downstream, or better yet we should get around to tightening down our sandbox. @Gabriel439, take a look at the changes that remain. Sorry for the delay getting back to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to fix warnings for the CI build to pass. See: https://hydra.dhall-lang.org/build/102162
network-tests
flag to toggle tests which require internet
@Gabriel439, it seems like the warnings are originating from the |
Allows for disabling network-dependent tests independently of the `with-http` flag.
a18e744
to
8959873
Compare
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
Thank you! 🙂 |
Some extra stuff that would help tests run with Gentoo's network-disabled sandbox and system-installed Haskell packages.