Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network-tests flag to toggle tests which require internet #2383

Conversation

hololeap
Copy link

Some extra stuff that would help tests run with Gentoo's network-disabled sandbox and system-installed Haskell packages.

@hololeap hololeap force-pushed the fix_without_http_tests branch from 65426df to 6e9b65f Compare February 13, 2022 18:40
@hololeap hololeap marked this pull request as draft February 13, 2022 18:45
Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I'm ready to merge whenever this is done

@hololeap hololeap force-pushed the fix_without_http_tests branch from fe7a58c to a1427e8 Compare February 13, 2022 22:09
@sjakobi
Copy link
Collaborator

sjakobi commented Feb 13, 2022

@hololeap AFAIK using cabal-doctest causes issues with cross-compilation. Compare #1297.

(CC @vmchale in case this info is outdated.)

@hololeap hololeap force-pushed the fix_without_http_tests branch from a7ceb49 to 1de76ad Compare March 20, 2022 21:27
@hololeap
Copy link
Author

I'm abandoning getting cabal-doctest working. It's a nice workaround for our purposes, but it's simple enough to patch it downstream, or better yet we should get around to tightening down our sandbox.

@Gabriel439, take a look at the changes that remain. Sorry for the delay getting back to this.

@hololeap hololeap marked this pull request as ready for review March 20, 2022 21:32
Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to fix warnings for the CI build to pass. See: https://hydra.dhall-lang.org/build/102162

@hololeap hololeap changed the title Gentoo compatibility for tests Add network-tests flag to toggle tests which require internet Mar 22, 2022
@hololeap
Copy link
Author

@Gabriel439, it seems like the warnings are originating from the dhall-lang:gabriella/fix_without_http_tests branch that I'm trying to merge onto.

Allows for disabling network-dependent tests independently of the `with-http`
flag.
@hololeap hololeap force-pushed the fix_without_http_tests branch from a18e744 to 8959873 Compare March 22, 2022 18:31
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
@Gabriella439 Gabriella439 merged commit 4c87963 into dhall-lang:gabriella/fix_without_http_tests Mar 22, 2022
@Gabriella439
Copy link
Collaborator

Thank you! 🙂

@hololeap hololeap deleted the fix_without_http_tests branch March 22, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants