Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reset-password): allow resetting password via context menu #805

Merged
7 commits merged into from
Aug 31, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2021

https://jira.dhis2.org/browse/DHIS2-11268

  • Translate context menu label
  • Add proper context menu icon
  • Hide snackbar on success and show error message on failure

Follow up:

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Aug 30, 2021

🚀 Deployed on https://pr-805--dhis2-user.netlify.app

@ghost ghost marked this pull request as ready for review August 31, 2021 08:29
@ghost ghost requested review from a team and mediremi August 31, 2021 08:29
Copy link
Contributor

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

I've left one comment about a potential superflous check, but that shouldn't impact functionality.

@ghost ghost force-pushed the DHIS2-11268 branch from 6217f60 to 3353985 Compare August 31, 2021 08:54
@ghost ghost merged commit d5fb507 into master Aug 31, 2021
@ghost ghost deleted the DHIS2-11268 branch August 31, 2021 09:39
dhis2-bot added a commit that referenced this pull request Aug 31, 2021
# [1.2.0](v1.1.21...v1.2.0) (2021-08-31)

### Features

* **reset-password:** allow resetting password via context menu ([#805](#805)) ([d5fb507](d5fb507))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants