-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tarfile support #192
Add tarfile support #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the f-strings are the cause of the Python 2.7 & 3.5 build failures. I don't know where we stand on Python version support for dials/data, so I'll defer to @Anthchirp.
I've made a suggestion about not necessarily extracting the entire archive if we don't need it. Not absolutely necessary but I could see it being useful for cases like https://zenodo.org/record/51405, which contain lots of tarballed sweeps from each of which one may only want a few images.
2.7 we can and should plausibly drop, so I've put in #193 for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it and see what happens
Two alternative implementations of adding tarfile support:
source["files"]
exist locally, and if not, decompress the tarfile (0429b7e)Minimal definition for 1. would be:
Whereas for 2. more information is required:
Fixes #11, fixes #12