-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial notebook for KernelSHAP for images. #126
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Kudos, SonarCloud Quality Gate passed! |
The explanation of model used to classify geometric shapes is hard to interpret, even after quite some finetuning of parameters. This is an known issue during the exploration stage when we tried to explain it with |
Still cannot fix the import error in the test of notebook |
I saw that error too, not sure what to do about it apart from trying the suggestions at the suggested URL. I haven't run into it on my laptop. Perhaps you can make an issue for it, if there isn't one already?
I agree, let's make an issue and look into it later. Is there a specific reason there are 2 notebooks for this method? I though we'd do one notebook for each modality/method combination. It would be a shame to throw away work put in the second notebook, so if we decide to keep one here, perhaps we could still store the other one in dianna-exploration. |
Patrick fixed the ipywidgets issue in another PR (#111), so we should be good on that front. |
Sounds good. I will make one issue.
Create issue #160 for it.
Thanks for your comment @loostrum . During the planning meeting we mentioned that for each tutorial notebook for images, we prefer to have one notebook per method unless the one that we already have is only MNIST. For kernelshap I started with MNIST (and the results look good). Given that currently no method makes use of geometric shapes, I also add one notebook for it. That's why. But I think it is ok to put them in the tutorial folder, although it is not necessary to mention them all in the documentation now. For later, the more the better, I guess :) |
Indeed, that one is fixed there. The fix was to just install ipywidgets :) So ece8305 can probably be reverted (if there's nothing else in there). Edit: I see now you actually added ipywidgets to the dependencies as well :) All the other stuff mentioned in the link seems unnecessary though, so that can be taken out of the notebook again. |
Thanks @egpbos for handling this :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tests pass on my laptop like this. Let's wait for CI and merge if everything is ok.
The dead link is not caused by this issue, so that's fine. |
|
@elboyran do you think those things need to be changed in this PR or should we create a new issue for them and merge now? |
For now
For now we can merge, but there are conflicts to resolve first. |
…dianna into 95-notebook-kernelshap-images
The conflicts are resolved. I will merge this branch. @elboyran I will add your comments into the existing issue #160 and get back to it later. Thanks for the suggestions! |
Two notebooks are added/revised to showcase the KernelSHAP implementation in DIANNA:
These two notebooks are generated based on the old tutorial notebooks in DIANNA-exploration and DIANNA repo. Major changes include:
Close #95