Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIME on text tutorial #153

Merged
merged 3 commits into from
Jan 27, 2022
Merged

LIME on text tutorial #153

merged 3 commits into from
Jan 27, 2022

Conversation

loostrum
Copy link
Member

  • Adds the movie reviews dataset
  • Adds a LIME on text tutorial
  • Fixes bug in highlight_text (it wouldn't show the html properly)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@loostrum
Copy link
Member Author

@Reviewer: the notebooks action is failing, but not on the notebook added in this PR so I'm ignoring it :)

Copy link
Contributor

@loostrum, nice notebook. Would you consider adding link to the method on Zenodo (once we put all of them there)? Probably I should make an issue for that...

@loostrum
Copy link
Member Author

loostrum commented Jan 25, 2022

Thanks! I'd indeed change it once we have the models on zenodo (and we could then implement a download helper in dianna to automatically download them)
There's an issue already that somewhat covers it, I think: #108

@egpbos
Copy link
Member

egpbos commented Jan 26, 2022

We need to retrigger CI, could you do an amend commit (git commit --amend) or rebase on main (git rebase main inside the PR branch, I tried it, it rebases automatically without conflicts) and force push to trigger it?

@loostrum loostrum force-pushed the 96-tutorial-lime-text branch from be16d88 to 3271fa2 Compare January 26, 2022 12:02
@egpbos
Copy link
Member

egpbos commented Jan 26, 2022

Seems like this is ready, right?

@loostrum
Copy link
Member Author

Yep, didn't merge yet because I wasn't sure if Elena reviewed all changes.

@loostrum loostrum merged commit 5d1700a into main Jan 27, 2022
@loostrum loostrum deleted the 96-tutorial-lime-text branch January 27, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants