Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize CI pip dependency installation #167

Merged
merged 1 commit into from
Jan 27, 2022
Merged

optimize CI pip dependency installation #167

merged 1 commit into from
Jan 27, 2022

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Jan 27, 2022

This commit/PR:

  1. Adds the option in the install action to specify which extras-require options to use (dev, notebooks, publish).
  2. Uses the above to minimize the dependencies that have to be installed for each workflow.
  3. Installs wheel in the first step of the dependencies installation. This allows pip to download wheels in the second step (installing dianna and dependencies), which reduces install time.

@egpbos
optimize CI pip dependency installation
1cacfd3 
This commit:
1. Adds the option in the install action to specify which extras-require options to use (dev, notebooks, publish).
2. Uses the above to minimize the dependencies that have to be installed for each workflow.
3. Installs wheel in the first step of the dependencies installation. This allows pip to download wheels in the second step (installing dianna and dependencies), which reduces install time.
@egpbos egpbos requested a review from cwmeijer January 27, 2022 14:19
loostrum
loostrum approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@loostrum loostrum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, faster CI, fewer dependencies: I like it. Merge it!

@egpbos egpbos merged commit 6949108 into main Jan 27, 2022
@loostrum loostrum deleted the optimize_ci_dependencies branch February 11, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loostrum loostrum loostrum approved these changes

@cwmeijer cwmeijer Awaiting requested review from cwmeijer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egpbos @loostrum