Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create skeleton for joss paper #237

Merged
merged 4 commits into from
Feb 17, 2022
Merged

create skeleton for joss paper #237

merged 4 commits into from
Feb 17, 2022

Conversation

gcroci2
Copy link
Contributor

@gcroci2 gcroci2 commented Feb 15, 2022

No description provided.

@gcroci2 gcroci2 linked an issue Feb 15, 2022 that may be closed by this pull request
@gcroci2 gcroci2 added the publication papers, or presentations label Feb 15, 2022
@gcroci2 gcroci2 linked an issue Feb 15, 2022 that may be closed by this pull request
@elboyran elboyran self-requested a review February 16, 2022 14:19
Copy link
Contributor

@elboyran elboyran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

The link to the example figure fails. Maybe add a figure, e.g. the information one or the schematic one or even the logo, so it does pass?

@cwmeijer
Copy link
Member

Looks great!
I moved the files to their own folder as not to infuriate the protector of the root folder @egpbos :-)
I also made the figure link to our Dianna logo in order to make it pass the tests.
I approve it as it is of course (as I made the latest changes), if anyone (@gcroci2 perhaps?) agrees that this solves #182 then please merge this.

@egpbos
Copy link
Member

egpbos commented Feb 17, 2022

Before merging, be sure to check here whether it compiles as it should: https://whedon.theoj.org/

You can fill in gcroci2-182_skeleton_joss for the branch.

It compiles into something for me, but I didn't check whether it makes sense.

@egpbos
Copy link
Member

egpbos commented Feb 17, 2022

Actually, I think it's fine. I just tried on main as well, and that fails, because it obviously can't find paper.md there. So, lgtm!

@gcroci2 gcroci2 merged commit 4b97e9e into main Feb 17, 2022
@gcroci2 gcroci2 deleted the gcroci2-182_skeleton_joss branch February 17, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publication papers, or presentations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create bib skeleton file for Joss paper Create skeleton for Joss paper
4 participants