Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fair-software.yml #269

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Update fair-software.yml #269

merged 1 commit into from
Mar 21, 2022

Conversation

jspaaks
Copy link
Contributor

@jspaaks jspaaks commented Mar 17, 2022

Patched the howfairis github action, then updated the workflow here. Seems to work now:

https://github.com/dianna-ai/dianna/runs/5592260896?check_suite_focus=true

@jspaaks jspaaks marked this pull request as ready for review March 17, 2022 21:15
@elboyran elboyran mentioned this pull request Mar 18, 2022
@cwmeijer
Copy link
Member

I checked a couple of the failing tests. All of them only had problems finding a package:

     import tensorflow as tf
>   from tensorflow_probability import distributions as tfd
E   ModuleNotFoundError: No module named 'tensorflow_probability'

Sounds like something that broke in that package last week? I haven't looked into it further.

@elboyran
Copy link
Contributor

Merging in order to have the fair-software fix for the paper.

@elboyran elboyran merged commit 272d4b5 into dianna-ai:main Mar 21, 2022
@jspaaks jspaaks deleted the patch-1 branch March 21, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants