252 dashboard #291
252 dashboard #291
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
It's still not over, I just opened the PR to let you review/comment. |
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #1. X_test = open_image(path_gray)
Overwriting X_test with some tensor with another shape then before (3 axes instead of 4) results in an error later on (I think).
Reply via ReviewNB
| @@ -18,7 +18,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #13. pred_onnx = run_model(X_test)
This call errors as X_test does not have the correct dimensions for 'run_model' I think. The original X_test, before overwriting does have the correct dimensions.
Reply via ReviewNB
There was a problem hiding this comment.
Sorry for keeping you waiting. I think the code for the dashboard looks fine for now. Really great work! Excellent addition for the repo.
I just ran the notebook tests locally (ubuntu) and it passes on main, but errors on this PR's branch, just like it did on the server. That hints that there is indeed some error introduced on this branch. It would be great if we could look into the differences in that regard before merging.
I quickly looked into it. If you inspect the rise_mnist notebook here https://app.reviewnb.com/dianna-ai/dianna/pull/291/, you can see that there were some changes. I added to comments for you to see where I think the error is introduced.
Thanks! Now the errors have been fixed and all checks passed, so I merged with main. |
No description provided.