Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text visualization in dashboard #327

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix text visualization in dashboard #327

merged 1 commit into from
Sep 9, 2022

Conversation

loostrum
Copy link
Member

@loostrum loostrum commented Sep 7, 2022

When working on the tokenizers we changed how text visualization works, but didn't realize that the dashboard uses its own visualization function. This PR changes the dashboard visualization for text to work in the same way as in the main code

@loostrum loostrum requested a review from gcroci2 September 8, 2022 14:49
gcroci2
gcroci2 approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@gcroci2 gcroci2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have also run the dashboard locally using the code in this branch, and everything works well.

@loostrum loostrum merged commit 1a0020b into main Sep 9, 2022
@loostrum loostrum deleted the fix-text-dashboard branch September 9, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcroci2 gcroci2 gcroci2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loostrum @gcroci2