Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tutorial notebook for emulator use case #811

Merged
merged 33 commits into from
Aug 26, 2024
Merged

Add a tutorial notebook for emulator use case #811

merged 33 commits into from
Aug 26, 2024

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Jun 26, 2024 •
edited
Loading

closes #759
closes #760
closes #761
closes #762
closes #803

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@SarahAlidoost SarahAlidoost marked this pull request as ready for review August 7, 2024 13:04
@SarahAlidoost SarahAlidoost requested a review from cwmeijer August 7, 2024 13:05
cwmeijer
cwmeijer requested changes Aug 8, 2024
View reviewed changes
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is a really nice notebook with a great story! Thanks a lot for the work you put in to this. I added my comments in reviewNB with suggestions for some minor improvements.

@SarahAlidoost
Copy link
Member Author

Great work! This is a really nice notebook with a great story! Thanks a lot for the work you put in to this. I added my comments in reviewNB with suggestions for some minor improvements.

thanks for reviewing. I checked the reviewNB of this pull request and couldn't find any comments 🤔 Can you please send me a link to your comments?

@SarahAlidoost SarahAlidoost mentioned this pull request Aug 16, 2024
Closed
@elboyran
Update README.md
64b8a28 
Fixed the links to the example images.
elboyran and others added 10 commits August 21, 2024 10:21
@elboyran
Update README.md
84a5c4b 
Example image for the Land atmosphere dataset
@elboyran
Update README.md
304e942 
Fixing the penguin dataset logo
@elboyran
Update README.md
da56fda 
Adding logo for the land atmosphere dataset
@elboyran
Update tutorals README.md
45e9f00 
Fixing the RISE tabular penguin link.
@elboyran
Update tutorial README.md
3b6c048 
Adding logo and link to the land atmospheric task.
TO DO: add the Kernal SHAP hyper-parameters used.
@elboyran
Update tutorial README.md
8292c6b 
Editing the task description.
@elboyran
Update tutorials README.md
c2755d0 
Fixed subscript formatting
@SarahAlidoost
add kernelshap hyperparameters related to emulator nb
995ae8a
@SarahAlidoost
add explanation about physical model related to emulator nb
33e9a2f
@SarahAlidoost
improve the intro of emulator nb
c01ad12
@SarahAlidoost
Copy link
Member Author

I addressed comments from @cwmeijer and @elboyran . The failing tests in github actions are due to #842

@SarahAlidoost SarahAlidoost merged commit 9f01b93 into main Aug 26, 2024
12 of 17 checks passed
@SarahAlidoost SarahAlidoost deleted the add_emulator_nb branch August 26, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@SarahAlidoost @cwmeijer @elboyran