Fix notebook tests #851
Merged
Fix notebook tests #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…large memory footprint in e.g. lime_images tutorial
|
The only test still failing is dashboard related, unrelated to this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first change I made the Python version used to run the tutorial notebooks more robust in the CI file. This is not that important, but was mainly so I could open a PR and trigger the CI to run on the notebooks.
The failing tests seem to be due to the Github runner being out of memory. I noticed locally that the lime_images tutorial uses all my available RAM. The test does pass locally, but perhaps this is the issue. There is an option to disable some pre-allocation of memory by ONNX, see here.
I've added that option to our
SimpleModelRunner. This drastically reduces the memory usage.Tests now pass on CI as well.