Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing of tutorial notebooks using nbmake #90

Merged
merged 6 commits into from
Jan 20, 2022
Merged

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Dec 24, 2021

Fixes #89.

@egpbos egpbos added the devops label Dec 24, 2021
@cwmeijer cwmeijer marked this pull request as draft January 18, 2022 15:37
@cwmeijer
Copy link
Member

As it's still failing tests and there is no recent activity, we don't think you want us to review it, so I changed it to draft. ♥

@egpbos egpbos force-pushed the test_notebooks branch 2 times, most recently from 82ff299 to 9ce5655 Compare January 19, 2022 15:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@egpbos egpbos marked this pull request as ready for review January 20, 2022 09:24
@egpbos
Copy link
Member Author

egpbos commented Jan 20, 2022

Ok, reviewers, this PR now does three four things:

  1. Add nbmake jobs, which, obviously, fail currently. I opted not to fix them here, but just let them fail, since people are still working on the notebooks in other PRs as well. This is also the reason I made them separate jobs, instead of including them in the build jobs; build then still passes, as it should.
  2. Use a new Actions feature called Composite Actions to remove duplication from the jobs. I added a custom Action that installs Python, DIANNA and dependencies. This action is then referenced from all the other jobs.
  3. The new Action also has an added feature: it caches pip. This could be faster than reinstalling every time. It could also be slower :D This is just an experiment.
  4. Renamed the build job to just "build" (see Badges & additional readme paragraphs #52).

Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nbmake command locally. looks ok. Great addition.
Refactoring makes sense 👍
Thanks for the renaming of 'build' :-)
lgtm+

@egpbos egpbos merged commit 6629b4d into main Jan 20, 2022
@egpbos egpbos mentioned this pull request Jan 20, 2022
6 tasks
@loostrum loostrum deleted the test_notebooks branch January 21, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test notebooks in CI
2 participants