-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing of tutorial notebooks using nbmake #90
Conversation
As it's still failing tests and there is no recent activity, we don't think you want us to review it, so I changed it to draft. ♥ |
096a409
to
711ae9b
Compare
e7c2a41
to
7c2dc58
Compare
82ff299
to
9ce5655
Compare
9bd36c6
to
92c2414
Compare
bf4fac4
to
20873bc
Compare
Kudos, SonarCloud Quality Gate passed! |
Ok, reviewers, this PR now does
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested nbmake command locally. looks ok. Great addition.
Refactoring makes sense 👍
Thanks for the renaming of 'build' :-)
lgtm+
Fixes #89.