Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp tests have flaky timeouts on Windows #4904

Closed
cocreature opened this issue Mar 9, 2020 · 0 comments · Fixed by #11442
Closed

lsp tests have flaky timeouts on Windows #4904

cocreature opened this issue Mar 9, 2020 · 0 comments · Fixed by #11442
Labels
language/now Language team priority NOW language Language team work
Milestone
[Deprecated use c...

Comments

@cocreature
Copy link
Contributor

For reasons I do not understand the lsp tests sometimes time out on Windows.

This always seems to happen in the multi-package tests. There doesn’t seem to be any useful error indicating what is going wrong.
@cocreature cocreature added language/now Language team priority NOW language Language team work labels Mar 9, 2020
sofiafaro-da added a commit that referenced this issue Sep 9, 2020
@sofiafaro-da
Disable multi-package lsp-tests on windows.
e3c2209 
These are consistently timing out on Windows for unknown reasons.
Disabling until we figure out how to fix the tests. See #4904

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Sep 9, 2020
Merged
mergify bot pushed a commit that referenced this issue Sep 9, 2020
@sofiafaro-da
Disable multipackage LSP tests on Windows. (#7360)
220cfc5 
* Disable multi-package lsp-tests on windows.

These are consistently timing out on Windows for unknown reasons.
Disabling until we figure out how to fix the tests. See #4904

changelog_begin
changelog_end

* fix definition
@hurryabit hurryabit added this to the DAML Compiler milestone Sep 14, 2020
cocreature added a commit that referenced this issue Oct 28, 2021
@cocreature
Drop flaky marker from lsp-tests
eee82a5 
I can’t reproduce flakiness anymore. I suspect #11395 fixed it.

fixes #4904

changelog_begin
changelog_end
@cocreature cocreature mentioned this issue Oct 28, 2021
Merged
7 tasks
cocreature added a commit that referenced this issue Oct 28, 2021
@cocreature
Drop flaky marker from lsp-tests (#11442)
d8b92b7 
I can’t reproduce flakiness anymore. I suspect #11395 fixed it.

fixes #4904

changelog_begin
changelog_end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language/now Language team priority NOW language Language team work
Projects
None yet
Milestone
[Deprecated use compiler project] Dam...
Development

Successfully merging a pull request may close this issue.

Drop flaky marker from lsp-tests digital-asset/daml
2 participants
@cocreature @hurryabit