Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port upgrade matrix to integration #20829

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Port upgrade matrix to integration #20829

wants to merge 3 commits into from

Conversation

samuel-williams-da
Copy link
Contributor

No description provided.

samuel-williams-da
samuel-williams-da commented Mar 4, 2025
View reviewed changes
sdk/daml-lf/engine/src/test/scala/com/digitalasset/daml/lf/engine/UpgradeTest.scala
Comment on lines +506 to +508
// change `p` on Client to alice, add bob
// update Mod:alice and Mod:bob to index that instead
// drop alice and bob from common defs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

@samuel-williams-da
Copy link
Contributor Author

Had to change the engine suite to an AsyncWordSpec, which makes it much slower and is now timing out of 300s
The new suite, which runs 1900 tests against canton is timing out on 900s, locally it took 1hr15 to run.
Its also failing on the ChangedMaintainers tests where upgrade errors are expected, as we're instead getting ContractKeyNotFOund and Authorization errors.
Given I've confirmed locally that nothing is actually broken, I'm going to leave this to the backburner for a little bit while I work on more pressing issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbrauner-da paulbrauner-da Awaiting requested review from paulbrauner-da

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samuel-williams-da