Acquired interface query/subscription filters #20840
Draft
+29
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylant-da
changed the title
dylant-da
changed the base branch from
main
to
dylant-da/acquired-interfaces-allow-view-changes-and-new-instances
dylant-da
force-pushed
the
dylant-da/acquired-interfaces-filters
branch
from
18f4952 to
4636dd6
Compare
Also add a bunch of unnecessary logging - removing in next commit.
dylant-da
force-pushed
the
dylant-da/acquired-interfaces-filters
branch
from
4636dd6 to
6026b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until #20818 goes in
Implementing acquired interface filters
At time of opening this PR, just a basic implementation doing the simplest possible thing
I'll move this over to Canton next week and start running tests there.