godo/kubernetes: add maintenance policy support #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouk
suggested changes
Apr 15, 2019
kubernetes.go
Outdated
|
|
||
| func (k KubernetesMaintenancePolicyDay) MarshalJSON() ([]byte, error) { | ||
| if KubernetesMaintenanceDayAny <= k && k <= KubernetesMaintenanceDaySunday { | ||
| return []byte(`"` + days[k] + `"`), nil |
There was a problem hiding this comment.
Same as above, can be replaced by return json.Marshal(days[k]).
There was a problem hiding this comment.
What do you mean by above?
There was a problem hiding this comment.
Sorry, my comments got out of order. I mean like the comment I made on line 172, just replace line 178 with return json.Marshal(days[k])
This PR adds the maintenance policy support for the upcoming Maintenance Window feature on the Managed Kubernetes service.
fatih
force-pushed
the
kubernetes-maintenance-policy
branch
from
0b49e8a to
f8bc115
Compare
|
@bouk force pushed the changes, PTAL. |
bouk
approved these changes
Apr 15, 2019
|
@bouk added tests as well. |
fatih
added a commit
to digitalocean/doctl
that referenced
this pull request
Apr 16, 2019
Create: ``` doctl kubernetes cluster create foo --maintenance-window monday=00:00 ``` Update: ``` doctl kubernetes cluster update foo --maintenance-window any=12:00 ``` There is no deletion of a maintenance policy as it's not needed. Depends on digitalocean/godo#224
fatih
added a commit
to digitalocean/doctl
that referenced
this pull request
Apr 18, 2019
Create: ``` doctl kubernetes cluster create foo --maintenance-window monday=00:00 ``` Update: ``` doctl kubernetes cluster update foo --maintenance-window any=12:00 ``` There is no deletion of a maintenance policy as it's not needed. Depends on digitalocean/godo#224
fatih
added a commit
to digitalocean/doctl
that referenced
this pull request
Apr 18, 2019
Create: ``` doctl kubernetes cluster create foo --maintenance-window monday=00:00 ``` Update: ``` doctl kubernetes cluster update foo --maintenance-window any=12:00 ``` There is no deletion of a maintenance policy as it's not needed. Depends on digitalocean/godo#224
fatih
added a commit
to digitalocean/doctl
that referenced
this pull request
Apr 18, 2019
Create: ``` doctl kubernetes cluster create foo --maintenance-window monday=00:00 ``` Update: ``` doctl kubernetes cluster update foo --maintenance-window any=12:00 ``` There is no deletion of a maintenance policy as it's not needed. Depends on digitalocean/godo#224
fatih
added a commit
to digitalocean/doctl
that referenced
this pull request
Apr 23, 2019
Create: ``` doctl kubernetes cluster create foo --maintenance-window monday=00:00 ``` Update: ``` doctl kubernetes cluster update foo --maintenance-window any=12:00 ``` There is no deletion of a maintenance policy as it's not needed. Depends on digitalocean/godo#224
fatih
added a commit
to digitalocean/doctl
that referenced
this pull request
Apr 24, 2019
Create: ``` doctl kubernetes cluster create foo --maintenance-window monday=00:00 ``` Update: ``` doctl kubernetes cluster update foo --maintenance-window any=12:00 ``` There is no deletion of a maintenance policy as it's not needed. Depends on digitalocean/godo#224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the maintenance policy support for the upcoming Maintenance
Window feature on the Managed Kubernetes service.