Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailsmtp: Allow authentication without SASL. #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/low-level/smtp/mailsmtp.c
Original file line number Diff line number Diff line change
Expand Up @@ -959,8 +959,8 @@ int auth_map_errors(int err)
}
}

#if 0
static int mailsmtp_auth_login(mailsmtp * session,
LIBETPAN_EXPORT
int mailsmtp_auth_login(mailsmtp * session,
const char * user, const char * pass)
{
int err;
Expand Down Expand Up @@ -1008,7 +1008,6 @@ static int mailsmtp_auth_login(mailsmtp * session,

return err;
}
#endif

int mailsmtp_auth_type(mailsmtp * session,
const char * user, const char * pass, int type)
Expand Down Expand Up @@ -1634,16 +1633,19 @@ void mailsmtp_set_logger(mailsmtp * session, void (* logger)(mailsmtp * session,
session->smtp_logger_context = logger_context;
}

LIBETPAN_EXPORT
int mailsmtp_send_command(mailsmtp * f, char * command)
{
return send_command(f, command);
}

LIBETPAN_EXPORT
int mailsmtp_send_command_private(mailsmtp * f, char * command)
{
return send_command_private(f, command, 0);
}

LIBETPAN_EXPORT
int mailsmtp_read_response(mailsmtp * session)
{
return read_response(session);
Expand Down
10 changes: 10 additions & 0 deletions src/low-level/smtp/mailsmtp.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ int mailsmtp_connect(mailsmtp * session, mailstream * s);
LIBETPAN_EXPORT
int mailsmtp_quit(mailsmtp * session);

int mailsmtp_auth_login(mailsmtp * session, const char * user, const char * pass);

/* This call is deprecated and mailesmtp_auth_sasl() should be used instead */
/**
Expand Down Expand Up @@ -184,6 +185,15 @@ LIBETPAN_EXPORT
void mailsmtp_set_logger(mailsmtp * session, void (* logger)(mailsmtp * session, int log_type,
const char * str, size_t size, void * context), void * logger_context);

LIBETPAN_EXPORT
int mailsmtp_send_command(mailsmtp * f, char * command);

LIBETPAN_EXPORT
int mailsmtp_send_command_private(mailsmtp * f, char * command);

LIBETPAN_EXPORT
int mailsmtp_read_response(mailsmtp * session);

#ifdef __cplusplus
}
#endif
Expand Down