Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Cleaning #170

Open
5 of 14 tasks
jtfairbank opened this issue Apr 6, 2022 · 7 comments
Open
5 of 14 tasks

Spring Cleaning #170

jtfairbank opened this issue Apr 6, 2022 · 7 comments
Assignees
@jtfairbank
Labels
Refactor Cleanup part of the codebase without changing functionality

Comments

@jtfairbank
Copy link
Contributor

jtfairbank commented Apr 6, 2022 •
edited
Loading

It's been a minute since I had a chance to code, so now's a good time to do some maintenance work as I get back up to speed.

Remove Unused Components

(CodeSee Map)

  • DropdownMenu
  • Animation
  • Card
  • Badge

Review & Refactor Static Pages

  • Home
  • About Us
  • Donate

Review & Refactor Route Pages

Remove unused Contentful-powered functionality:

Be sure to remove unnecessary entries from Contentful, but save the content if it's usable.

  • Taylor's over-architected site / pages / menu setup.
  • Unused content types.
  • Stale content types / data (i.e. previous round of needs assessment).
  • Check for duplicate entries & resolve.

Review Docs & Dev Experience

  • README
  • Document the many config files. Loom? CodeSee Maps?
@jtfairbank jtfairbank added documentation Refactor Cleanup part of the codebase without changing functionality labels Apr 6, 2022
@jtfairbank jtfairbank self-assigned this Apr 6, 2022
@jtfairbank jtfairbank mentioned this issue Apr 6, 2022
Merged
@jtfairbank
Copy link
Contributor Author

Hey @deammer is there a specific reason you created the HomePage and AboutUsPage as templates instantiated in /gatsby-node.js? As opposed to creating them as pages in /src/pages and keeping the page query with the page, like Donate or Shipments?

Wondering if I can safely refactor them into pages.

@deammer
Copy link
Collaborator

deammer commented Apr 6, 2022

Hey @jtfairbank! I am actually not sure why I did it that way instead of co-locating the queries 🤔 Maybe that involved some complexity that I didn't want to deal with when we were shipping the new site? My memory is terrible 😅 If you refactor it, please let me know what you find out!

@jtfairbank
Copy link
Contributor Author

Word up! And yeah that makes sense. You were in "get it launched" mode. 😆

@jtfairbank
Copy link
Contributor Author

@deammer figured it out! See the last 2 commits on #171 for the setup using Forestry => Gatsby Pages using page queries instead of Forestry => Gatsby Templates hooked up in gatsby-node.js. Please do leave me a note if you spot anything I didn't, though! :)

@deammer
Copy link
Collaborator

deammer commented Apr 6, 2022

@jtfairbank #171 doesn't seem quite right, that's a dependency upgrade

@jtfairbank
Copy link
Contributor Author

@deammer whoops! #172

@deammer
Copy link
Collaborator

deammer commented Apr 6, 2022

👏 very nice!

jtfairbank added a commit that referenced this issue Apr 13, 2022
@jtfairbank
Chore / Refactor: Spring Cleaning (#172)
1a106f2 
Partially addresses #170 

* chore: Remove unused DropdownMenu component.

* chore: Remove unused Spinner animation component.

* chore: Remove unused card components (CardGrid & ServiceCard).

* chore: Remove unused Badge component.

* refactor: Gatsby Templates => Gatsby Pages for the Forestry sourced single pages (Home, About Us).

* refactor: Gatsby Templates => Gatsby Pages for the Forestry sourced Home page.
@jtfairbank jtfairbank mentioned this issue Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtfairbank jtfairbank

Labels
Refactor Cleanup part of the codebase without changing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jtfairbank @deammer @LauraLangdon