Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routes refactor: reservations section #804

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Routes refactor: reservations section #804

merged 3 commits into from
Oct 25, 2022
+190 −155

Conversation

RabeaGleissner
Copy link
Contributor

Related issue: #777

  • created Reservations component (I feel like that could be DRYed up more but I guess how it is now is already an improvement. I'll continue with the refactor later and see if I can improve it)
  • created SectionTitle component

@ghost
Copy link

ghost commented Oct 25, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

jtfairbank
jtfairbank approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jtfairbank jtfairbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jtfairbank jtfairbank merged commit 8b155f3 into distributeaid:saga Oct 25, 2022
@RabeaGleissner RabeaGleissner deleted the routes_refactor_reservations_component branch October 26, 2022 05:39
@jtfairbank jtfairbank added the hacktoberfest-accepted Hacktober Fest PR Accepted label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtfairbank jtfairbank jtfairbank approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktober Fest PR Accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RabeaGleissner @jtfairbank