Fix effect properties ignored #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix effect properties being ignored because there's no `EffectProperties` component (and no code to auto-spawn it, despite the documentation stating otherwise). Require the component instead to be added always, and add it to `ParticleEffectBundle`. The alternative of auto-spawning is rendered complex by the fact the decision requires inspected the `EffectAsset`'s `Module` looking for properties, which requires multiple levels of indirection, so would be rather expensive to execute each frame on effects which doesn't require the component (so keep not having it and require to be re-checked each frame). Fixes #309
djeedai
added
C - bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix effect properties being ignored because there's no
EffectPropertiescomponent (and no code to auto-spawn it, despite the documentation stating otherwise). Require the component instead to be added always, and add it toParticleEffectBundle. The alternative of auto-spawning is rendered complex by the fact the decision requires inspected theEffectAsset'sModulelooking for properties, which requires multiple levels of indirection, so would be rather expensive to execute each frame on effects which doesn't require the component (so keep not having it and require to be re-checked each frame).Fixes #309