Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove z_layer_2d #429

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Remove z_layer_2d #429

merged 1 commit into from
Mar 10, 2025

Conversation

djeedai
Copy link
Owner

@djeedai djeedai commented Mar 10, 2025

Remove ParticleEffect::z_layer_2d in favor of just using the effect Transform's Z coordinate. This makes ordering particle effects in layers (along Z) more consistent and expected.

Fixes #423

Remove `ParticleEffect::z_layer_2d` in favor of just using the effect
`Transform`'s Z coordinate. This makes ordering particle effects in
layers (along Z) more consistent and expected.

Fixes #423
@djeedai djeedai added C - bug Something isn't working C - breaking change A breaking API or behavior change A - components Change related to an ECS component labels Mar 10, 2025
@djeedai djeedai merged commit 20aa419 into main Mar 10, 2025
15 checks passed
@djeedai djeedai deleted the u/no-z-layer-2d branch March 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A - components Change related to an ECS component C - breaking change A breaking API or behavior change C - bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

z_layer_2d is both confusing and buggy, should be removed
1 participant