make compatible with automake >=1.13, distributions which no longer support indirect symbol resolution #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systems which do not support indirect symbol resolution (Ubuntu >= 11.10, Debian > Wheezy(?), Fedora >=13) require that liblua.so be linked with -lm and -ldl, else linking against it will cause undefined symbol errors in liblua.so.
akheron
added a commit
that referenced
this pull request
Jan 7, 2014
make compatible with automake >=1.13, distributions which no longer support indirect symbol resolution
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automake >=1.13 runs tests in parallel mode by default; the old serial tests fail to run. I've added the necessary automake option to use serial tests.
Many Linux distributions no longer support indirect symbol resolution (see https://wiki.debian.org/ToolChain/DSOLinking, https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition) which causes linking of lua.o against liblua.so to fail, as liblua.so did not explicitly link against libm and libdl. I've added explicit dependencies to liblua.so