fix to not explicitely link against ncurses #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to explicitely link against libncurses because linking against libreadline will pull in the libraries it depends on. One should also note, that ncurses libraries can be build seperately, which means that readline (if configured to use curses instead of termcap) will be only linked against libtinfo.
akheron
added a commit
that referenced
this pull request
Feb 29, 2012
…97cf5 fix to not explicitely link against ncurses
|
Merged, thanks! |
|
You are welcome! ;) I have 3 more commits within my forked repository majorly improving the installation of documentation when calling make install (most probably not that important for people building from spec files but for those relying on make install) Cheers |
|
Yeah, those changes look good to me, too. Could you squash them to a single commit and send a pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to explicitely link against libncurses because linking against
libreadline will pull in the libraries it depends on.
One should also note, that ncurses libraries can be build seperately, which
means that readline (if configured to use curses instead of termcap) will be
only linked against libtinfo.