Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose TCK Validation extension to check for DMN namespace uniqueness #294

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented May 9, 2019

within each given TCK test case folder(s).

@tarilabs
Copy link
Member Author

tarilabs commented May 9, 2019

Demonstration using 193cf93

image

in job log tail:
image

in job log is reported the full exception message:
image

testDMNFilesUniqueInNamespace[TestCase 0001-filter](org.omg.dmn.tck.validation.TestCasesFiles)  Time elapsed: 0.007 sec  <<< ERROR!
java.lang.RuntimeException: There are 2 or more files with the same DMN namespace: http://www.trisotech.com/definitions/_f52ca843-504b-4c3b-a6bc-4d377bffef7a
in the folder: ../../TestCases/compliance-level-3/0001-filter
these files are: [../../TestCases/compliance-level-3/0001-filter/0001-filter.dmn, ../../TestCases/compliance-level-3/0001-filter/0001-filter2.dmn]

@tarilabs
Copy link
Member Author

tarilabs commented May 9, 2019

If there is consensus about namespace uniqueness between models which are related by an import relationship as per #272 (comment) then this TCK Validation test case folder check:

ensures within a given TCK test case folder, the *.dmn models file have a unique namespace --within that TCK test case folder.

@StrayAlien
Copy link
Contributor

Thanks @tarilabs - seems fair enough given the recent discussions.

@agilepro
Copy link
Contributor

discussed on May 24. Agreed that this is OK to go. Just waiting for the end of the month.

@tarilabs tarilabs merged commit 70c7804 into dmn-tck:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants