Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROS] bump ROS package versions, Iron target final snapshot before retirement #18594

Merged
merged 1 commit into from
Mar 10, 2025
Merged

[ROS] bump ROS package versions, Iron target final snapshot before retirement #18594

merged 1 commit into from
Mar 10, 2025

Conversation

mikaelarguedas
Copy link
Contributor

No description provided.

@mikaelarguedas
bump ROS package versions and iron target final snapshot before retir…
afd43be 
…ement

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas requested a review from a team as a code owner March 9, 2025 12:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2025

Diff for afd43be: 
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 956128a..833290c 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -13,7 +13,7 @@ Directory: ros/humble/ubuntu/jammy/ros-base
 
 Tags: humble-ros-core, humble-ros-core-jammy
 Architectures: amd64, arm64v8
-GitCommit: 27cc0b68263bbbb10bb58dd814efc0a6b0a01ec7
+GitCommit: b525e9ef659ce448db6150fd5407ef62b2c5b265
 Directory: ros/humble/ubuntu/jammy/ros-core
 
 Tags: iron-perception, iron-perception-jammy
@@ -28,7 +28,7 @@ Directory: ros/iron/ubuntu/jammy/ros-base
 
 Tags: iron-ros-core, iron-ros-core-jammy
 Architectures: amd64, arm64v8
-GitCommit: 27cc0b68263bbbb10bb58dd814efc0a6b0a01ec7
+GitCommit: 2ad854492209b8dbab303578a5baedab4d5ab41d
 Directory: ros/iron/ubuntu/jammy/ros-core
 
 Tags: jazzy-perception, jazzy-perception-noble
@@ -43,7 +43,7 @@ Directory: ros/jazzy/ubuntu/noble/ros-base
 
 Tags: jazzy-ros-core, jazzy-ros-core-noble
 Architectures: amd64, arm64v8
-GitCommit: 74e321bc1837c29f223a6d54895aa3c8eb184119
+GitCommit: b525e9ef659ce448db6150fd5407ef62b2c5b265
 Directory: ros/jazzy/ubuntu/noble/ros-core
 
 Tags: noetic-perception, noetic-perception-focal
@@ -63,20 +63,20 @@ Directory: ros/noetic/ubuntu/focal/ros-base
 
 Tags: noetic-ros-core, noetic-ros-core-focal
 Architectures: amd64, arm32v7, arm64v8
-GitCommit: 27cc0b68263bbbb10bb58dd814efc0a6b0a01ec7
+GitCommit: b525e9ef659ce448db6150fd5407ef62b2c5b265
 Directory: ros/noetic/ubuntu/focal/ros-core
 
 Tags: rolling-perception, rolling-perception-noble
 Architectures: amd64, arm64v8
-GitCommit: 7f98ddd88d872299c45b60c8bcd70d4eb6665222
+GitCommit: 2e9b4e3c02bff2c70271e6f0fd15d4132e8cbcbb
 Directory: ros/rolling/ubuntu/noble/perception
 
 Tags: rolling-ros-base, rolling-ros-base-noble, rolling
 Architectures: amd64, arm64v8
-GitCommit: 7f98ddd88d872299c45b60c8bcd70d4eb6665222
+GitCommit: 2e9b4e3c02bff2c70271e6f0fd15d4132e8cbcbb
 Directory: ros/rolling/ubuntu/noble/ros-base
 
 Tags: rolling-ros-core, rolling-ros-core-noble
 Architectures: amd64, arm64v8
-GitCommit: 7f98ddd88d872299c45b60c8bcd70d4eb6665222
+GitCommit: 2e9b4e3c02bff2c70271e6f0fd15d4132e8cbcbb
 Directory: ros/rolling/ubuntu/noble/ros-core
diff --git a/ros_humble-ros-core-jammy/Dockerfile b/ros_humble-ros-core-jammy/Dockerfile
index a142dd9..8f6138d 100644
--- a/ros_humble-ros-core-jammy/Dockerfile
+++ b/ros_humble-ros-core-jammy/Dockerfile
@@ -29,10 +29,10 @@ RUN set -eux; \
 RUN echo "deb [ signed-by=/usr/share/keyrings/ros2-latest-archive-keyring.gpg ] http://packages.ros.org/ros2/ubuntu jammy main" > /etc/apt/sources.list.d/ros2-latest.list
 
 # setup environment
-ENV LANG C.UTF-8
-ENV LC_ALL C.UTF-8
+ENV LANG=C.UTF-8
+ENV LC_ALL=C.UTF-8
 
-ENV ROS_DISTRO humble
+ENV ROS_DISTRO=humble
 
 # install ros2 packages
 RUN apt-get update && apt-get install -y --no-install-recommends \
diff --git a/ros_iron-ros-core-jammy/Dockerfile b/ros_iron-ros-core-jammy/Dockerfile
index a0e9dd3..172d938 100644
--- a/ros_iron-ros-core-jammy/Dockerfile
+++ b/ros_iron-ros-core-jammy/Dockerfile
@@ -17,22 +17,22 @@ RUN apt-get update && apt-get install -q -y --no-install-recommends \
 
 # setup keys
 RUN set -eux; \
-       key='C1CF6E31E6BADE8868B172B4F42ED6FBAB17C654'; \
+       key='4B63CF8FDE49746E98FA01DDAD19BAB3CBF125EA'; \
        export GNUPGHOME="$(mktemp -d)"; \
        gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key"; \
        mkdir -p /usr/share/keyrings; \
-       gpg --batch --export "$key" > /usr/share/keyrings/ros2-latest-archive-keyring.gpg; \
+       gpg --batch --export "$key" > /usr/share/keyrings/ros2-snapshots-archive-keyring.gpg; \
        gpgconf --kill all; \
        rm -rf "$GNUPGHOME"
 
 # setup sources.list
-RUN echo "deb [ signed-by=/usr/share/keyrings/ros2-latest-archive-keyring.gpg ] http://packages.ros.org/ros2/ubuntu jammy main" > /etc/apt/sources.list.d/ros2-latest.list
+RUN echo "deb [ signed-by=/usr/share/keyrings/ros2-snapshots-archive-keyring.gpg ] http://snapshots.ros.org/iron/final/ubuntu jammy main" > /etc/apt/sources.list.d/ros2-snapshots.list
 
 # setup environment
-ENV LANG C.UTF-8
-ENV LC_ALL C.UTF-8
+ENV LANG=C.UTF-8
+ENV LC_ALL=C.UTF-8
 
-ENV ROS_DISTRO iron
+ENV ROS_DISTRO=iron
 
 # install ros2 packages
 RUN apt-get update && apt-get install -y --no-install-recommends \
diff --git a/ros_jazzy-ros-core-noble/Dockerfile b/ros_jazzy-ros-core-noble/Dockerfile
index 1cce1dc..397b97a 100644
--- a/ros_jazzy-ros-core-noble/Dockerfile
+++ b/ros_jazzy-ros-core-noble/Dockerfile
@@ -29,10 +29,10 @@ RUN set -eux; \
 RUN echo "deb [ signed-by=/usr/share/keyrings/ros2-latest-archive-keyring.gpg ] http://packages.ros.org/ros2/ubuntu noble main" > /etc/apt/sources.list.d/ros2-latest.list
 
 # setup environment
-ENV LANG C.UTF-8
-ENV LC_ALL C.UTF-8
+ENV LANG=C.UTF-8
+ENV LC_ALL=C.UTF-8
 
-ENV ROS_DISTRO jazzy
+ENV ROS_DISTRO=jazzy
 
 # install ros2 packages
 RUN apt-get update && apt-get install -y --no-install-recommends \
diff --git a/ros_noetic-ros-core-focal/Dockerfile b/ros_noetic-ros-core-focal/Dockerfile
index 434ca83..358bd16 100644
--- a/ros_noetic-ros-core-focal/Dockerfile
+++ b/ros_noetic-ros-core-focal/Dockerfile
@@ -29,10 +29,10 @@ RUN set -eux; \
 RUN echo "deb [ signed-by=/usr/share/keyrings/ros1-latest-archive-keyring.gpg ] http://packages.ros.org/ros/ubuntu focal main" > /etc/apt/sources.list.d/ros1-latest.list
 
 # setup environment
-ENV LANG C.UTF-8
-ENV LC_ALL C.UTF-8
+ENV LANG=C.UTF-8
+ENV LC_ALL=C.UTF-8
 
-ENV ROS_DISTRO noetic
+ENV ROS_DISTRO=noetic
 
 # install ros packages
 RUN apt-get update && apt-get install -y --no-install-recommends \
diff --git a/ros_rolling-perception-noble/Dockerfile b/ros_rolling-perception-noble/Dockerfile
index 2749bfc..15c425f 100644
--- a/ros_rolling-perception-noble/Dockerfile
+++ b/ros_rolling-perception-noble/Dockerfile
@@ -4,6 +4,6 @@ FROM ros:rolling-ros-base-noble
 
 # install ros2 packages
 RUN apt-get update && apt-get install -y --no-install-recommends \
-    ros-rolling-perception=0.11.0-1* \
+    ros-rolling-perception=0.12.0-1* \
     && rm -rf /var/lib/apt/lists/*
 
diff --git a/ros_rolling-ros-core-noble/Dockerfile b/ros_rolling-ros-core-noble/Dockerfile
index 1393a63..d2ed728 100644
--- a/ros_rolling-ros-core-noble/Dockerfile
+++ b/ros_rolling-ros-core-noble/Dockerfile
@@ -29,14 +29,14 @@ RUN set -eux; \
 RUN echo "deb [ signed-by=/usr/share/keyrings/ros2-latest-archive-keyring.gpg ] http://packages.ros.org/ros2/ubuntu noble main" > /etc/apt/sources.list.d/ros2-latest.list
 
 # setup environment
-ENV LANG C.UTF-8
-ENV LC_ALL C.UTF-8
+ENV LANG=C.UTF-8
+ENV LC_ALL=C.UTF-8
 
-ENV ROS_DISTRO rolling
+ENV ROS_DISTRO=rolling
 
 # install ros2 packages
 RUN apt-get update && apt-get install -y --no-install-recommends \
-    ros-rolling-ros-core=0.11.0-1* \
+    ros-rolling-ros-core=0.12.0-1* \
     && rm -rf /var/lib/apt/lists/*
 
 # setup entrypoint
diff --git a/ros_rolling/Dockerfile b/ros_rolling/Dockerfile
index 2986940..a041e87 100644
--- a/ros_rolling/Dockerfile
+++ b/ros_rolling/Dockerfile
@@ -26,6 +26,6 @@ RUN colcon mixin add default \
 
 # install ros2 packages
 RUN apt-get update && apt-get install -y --no-install-recommends \
-    ros-rolling-ros-base=0.11.0-1* \
+    ros-rolling-ros-base=0.12.0-1* \
     && rm -rf /var/lib/apt/lists/*

Relevant Maintainers:

@mikaelarguedas mikaelarguedas mentioned this pull request Mar 9, 2025
Merged
tfoote
tfoote reviewed Mar 9, 2025
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tianon tianon merged commit 02ef3d7 into docker-library:master Mar 10, 2025
10 checks passed
@mikaelarguedas mikaelarguedas deleted the ros_iron_eol branch March 10, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote left review comments

@tianon tianon tianon approved these changes

Assignees
No one assigned
Labels
library/ros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelarguedas @tianon @tfoote