-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENGDOCS-2451 #22117
ENGDOCS-2451 #22117
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/manuals/desktop/troubleshoot-and-support/troubleshoot/topics.md
Outdated
Show resolved
Hide resolved
content/manuals/desktop/troubleshoot-and-support/troubleshoot/topics.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I left one comment about using "Issue:" in the headings, this is totally my bad for not deleting that in the template, and one little nit for a missing ####Cause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more little fix I promise!! Craig introduced toc_max and toc_min values to the front matter so that we can control nesting in the toc. I updated the SSO troubleshooting guides and template to reflect this https://github.com/docker/docs/pull/22166/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* main: (42 commits) Update image source for kafbat Add missing release note to Docker Desktop release notes (docker#22218) Update build-summary.md feedback link fix: (docker#22212) some clarification on additional_contexts (docker#22204) Update windows-install.md (docker#22184) sso: add callout to certificate instructions (docker#22193) chore: cleanup includes w/ embedded shortcodes (docker#22191) fix: rendering issue w/ experimental labs include (docker#22190) billing: improve docs for manual payment retries (docker#22181) build: fix intro of distributed build section (docker#22189) dd-cli-cicd-fix (docker#22187) Update release note for 4.39 (docker#22188) Change directory after pulling a sample Docker application (docker#22179) Merge pull request docker#22117 from aevesdocker/ENGDOCS-2451 fix: troubleshooting toc fix (docker#22166) Add security section to 4.39.0 release notes (docker#22178) Merge pull request docker#22175 from aevesdocker/ENGDOCS-2470 Merge pull request docker#22160 from sarahsanders-docker/tcc-minutes hub: add troubleshooting (docker#22157) ...
Description
Am choosing to ignore Vale at this time
Related issues or tickets
Reviews