Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2451 #22117

Merged
merged 8 commits into from
Mar 6, 2025
Merged

ENGDOCS-2451 #22117

merged 8 commits into from
Mar 6, 2025

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Feb 27, 2025

Description

  • Gets the DD troubleshoot page into new format
  • Moves some FAQs into troubleshoot section
  • Removes a redundant page
  • Freshness on the pages
  • Freshness and tidy on DD FAQs as well

Am choosing to ignore Vale at this time

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Feb 27, 2025
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9fea886
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67c9665774c3cb00089109fb
😎 Deploy Preview https://deploy-preview-22117--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/get-started Relates to get started and onboarding docs area/guides labels Feb 28, 2025
@aevesdocker aevesdocker marked this pull request as ready for review February 28, 2025 10:25
@aevesdocker aevesdocker requested a review from a team February 28, 2025 10:25
Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I left one comment about using "Issue:" in the headings, this is totally my bad for not deleting that in the template, and one little nit for a missing ####Cause

Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more little fix I promise!! Craig introduced toc_max and toc_min values to the front matter so that we can control nesting in the toc. I updated the SSO troubleshooting guides and template to reflect this https://github.com/docker/docs/pull/22166/files

Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aevesdocker aevesdocker merged commit eb331a2 into docker:main Mar 6, 2025
13 of 14 checks passed
mdelapenya added a commit to mdelapenya/docker-docs that referenced this pull request Mar 11, 2025
* main: (42 commits)
  Update image source for kafbat
  Add missing release note to Docker Desktop release notes (docker#22218)
  Update build-summary.md
  feedback link fix: (docker#22212)
  some clarification on additional_contexts (docker#22204)
  Update windows-install.md (docker#22184)
  sso: add callout to certificate instructions (docker#22193)
  chore: cleanup includes w/ embedded shortcodes (docker#22191)
  fix: rendering issue w/ experimental labs include (docker#22190)
  billing: improve docs for manual payment retries (docker#22181)
  build: fix intro of distributed build section (docker#22189)
  dd-cli-cicd-fix (docker#22187)
  Update release note for 4.39 (docker#22188)
  Change directory after pulling a sample Docker application (docker#22179)
  Merge pull request docker#22117 from aevesdocker/ENGDOCS-2451
  fix: troubleshooting toc fix (docker#22166)
  Add security section to 4.39.0 release notes (docker#22178)
  Merge pull request docker#22175 from aevesdocker/ENGDOCS-2470
  Merge pull request docker#22160 from sarahsanders-docker/tcc-minutes
  hub: add troubleshooting (docker#22157)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/get-started Relates to get started and onboarding docs area/guides status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants