-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support driver options in configuration #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 but please include docs :)
138e34d
to
74a8905
Compare
@malarzm finally done. While writing documentation, I noticed that it's a little ugly to create a service for the stream context, since the service definition needs a class name when it actually returns a scalar type:
It works just fine, it just isn't pretty. |
Thanks for the docs! |
@alcaeus @malarzm So, which one is it - doc's say driver_options while it infact is driverOptions :)
|
Yeah, getting the same fatal error issue as @peshi above after update. |
Thanks for the bug reports, I'll be fixing this shortly. In the meantime, please change your composer.json to use a stable release: |
@peshi I got confused while writing the docs. I'll be changing it to |
@peshi @The-Don-Himself I've fixed this in master, so there should be no discrepancies between code and docs and also no fatal error due to me not understanding types (😉 ). |
@alcaeus thanks for the hard-work! Its doesn't always have to be perfect, even Einstein got E = mc2 wrong several times before he could prove it. That said, you should probably re-check your coffee supply :) |
@The-Don-Himself checked and fixed 👍 |
@alcaeus No worries :) Thanks for the quick response and fix! 👍 |
Hello, How can I use the options while waiting for a stable version? I'm totally stuck in a cloud environment where Mongo comes with SSL, with no way to disable it. The driver_options is not recognized yet (I'm on the stable release), even though the documentations give the configuration to do it. Should I use the dev-master? I'd rather not, since there's a risk for a prod environment. Thanks! |
@sogetimaitral in that case, I'd suggest you use dev-master. I haven't had a lot of time in the past few weeks to take care of open issues, but I'll try to cut the 3.3 release ASAP. Looking at the 3.3 milestone, the only feature I'd definitely want in 3.3 is handling aggregation queries in the data collector, since we'll bring in aggregation builder with the upcoming ODM release. I'll see if I can build that data collector functionality soon and release 3.3 shortly thereafter. |
Thanks @alcaeus this is what I did, and it's working, but I'm not really at ease using a dev branch in a prod environment. |
Unfortunately, this isn't a fix, it's a new feature. Thus, according to Semantic Versioning which we follow, it requires a new minor release. Looking at the diff between 3.2 and dev-master, you shouldn't feel too bad about using a dev version - the changes are exclusively new features and docs updates. Still, I'll see to release 3.3 in the next couple of weeks. Maybe I can put the long weekend to good use. |
OK, I agree with your use of semantic versioning. Sorry for the extra work then... :( |
No worries - I should've gotten to it a while ago 😉 |
Fixes #380. With the release of doctrine/mongodb 1.4 it is possible to pass driver options to the underlying
MongoConnection
class. This allows users to specify a stream context containing options for SSL connections or logging.The stream context must be declared as a service and the service name given in the configuration for the connection.