Handle both ways of PDO reporting failed connection #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
issues/4267
branch
from
5a7479c to
4f2e60e
Compare
morozov
force-pushed
the
issues/4267
branch
from
4f2e60e to
34f3ced
Compare
|
|
greg0ire
approved these changes
Sep 11, 2020
phil-davis
reviewed
Sep 13, 2020
Comment on lines
+34
to
+36
| $sqlState = $exception->getSQLState(); | ||
|
|
||
| switch ($sqlState) { |
There was a problem hiding this comment.
It looks like this was not an essential part of the fix. $sqlState is only used by the switch statement anyway. But creating a local variable will do no harm.
There was a problem hiding this comment.
@phil-davis, you're right. It was introduced in the original version of this PR (5a7479c) which then had to be reworked. This chunk could have been reverted if noticed earlier.
rgrellmann
added a commit
to Rossmann-IT/dbal
that referenced
this pull request
Mar 7, 2021
Release 2.10.4 ====== - Total issues resolved: **2** - Total pull requests resolved: **3** - Total contributors: **3** Regressions ------------------------------ - [4255: Revert full support for foreign key constraints for SQLite](doctrine#4255) thanks to @morozov and @taylorotwell Bug fixes -------------- - [4268: Handle both ways of PDO reporting failed connection](doctrine#4268) thanks to @morozov CI improvements -------------- - [4252: Reuse global coding standard workflow](doctrine#4252) thanks to @greg0ire # gpg: Signature made Sat Sep 12 23:21:30 2020 # gpg: using RSA key 7A03FFFD3CFFEF053F88037A374EADAF543AE995 # gpg: Can't check signature: No public key # Conflicts: # README.md # lib/Doctrine/DBAL/Driver/OCI8/Driver.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4267.