Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Comparator::compare() #4722

Merged

Conversation

trompette
Copy link
Contributor

Q A
Type improvement
BC Break yes
Fixed issues none

Summary

The method has been deprecated and scheduled for removal since #4707.

@trompette trompette force-pushed the remove-deprecation-from-comparator branch from 6de842b to 3b7f8be Compare July 16, 2021 17:43
Copy link
Member

@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just one tiny comment.

@morozov morozov added this to the 4.0.0 milestone Jul 16, 2021
@trompette trompette force-pushed the remove-deprecation-from-comparator branch from 3b7f8be to 127430f Compare July 16, 2021 18:54
The method has been deprecated and scheduled for removal since doctrine#4707.
@trompette trompette force-pushed the remove-deprecation-from-comparator branch from 127430f to 14b57f6 Compare July 16, 2021 18:56
@morozov morozov merged commit dbe7bef into doctrine:4.0.x Jul 16, 2021
@morozov
Copy link
Member

morozov commented Jul 16, 2021

Thanks, @trompette!

@trompette trompette deleted the remove-deprecation-from-comparator branch July 16, 2021 21:03
@morozov morozov mentioned this pull request Oct 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants