Discriminator column empty value "IN" query

[Legion112]

Bug Report

Q	A
BC Break	no
Version	2.14.2

Summary

DiscriminatorMap adding empty value ('') to SQL query example:

Executing query: SELECT o0_.id AS id_0, o0_.amount AS amount_1, o0_.depositAddress AS depositAddress_2, o0_.name AS name_3, o0_.network AS network_4, o0_.type AS type_5 FROM operations o0_ WHERE o0_.type IN ('blockchain-in', 'expense', '')

This leads to error invalid input value when using Enum for Postgres DB

Current behavior

Adding o0_.type IN ('blockchain-in', 'expense', '') is incorrect and should be o0_.type IN ('blockchain-in', 'expense')

How to reproduce

I create a repository with an easy way to reproduce this issue.
It was introduced in version 2.14.2 prior to this version it was working as expected.

You could verify it by cloning the repository: https://github.com/Legion112/doctrine-playground
After cloning use docker for quick setup:

make shell 

After running the command below in logs you could see a wrong select statement

composer require doctrine/orm:2.14.2 -W && php index.php

I have confirmed that this version correctly was formatted correctly

Expected behavior

Executing query: SELECT o0_.id AS id_0, o0_.amount AS amount_1, o0_.depositAddress AS depositAddress_2, o0_.name AS name_3, o0_.network AS network_4, o0_.type AS type_5 FROM operations o0_ WHERE o0_.type IN ('blockchain-in', 'expense')

[JanTvrdik]

This error comes from Doctrine\ORM\Query\SqlWalker::generateDiscriminatorColumnConditionSQL(), because the discriminatorValue of a intermediate subclass will be null.

It is most likely caused by #10411.

Similar issue already fixed: #10643

---

It also emits to following error:

Deprecated: PDO::quote(): Passing null to parameter #1 ($string) of type string is deprecated in /app/vendor/doctrine/dbal/src/Driver/PDO/Connection.php on line 84

[mpdude]

Please report in #11200 whether it fixes this issue

[Legion112]

I have installed the patched on my tested project

I have tested it on my playground and I confirm that the patch will fix the issue with IN statement.

|

Some testing on real application could be done by my colleague @RalkeryBug
To test you would need to add fork repository:

    "repositories": [{
        "type": "vcs",
        "url": "https://github.com/DemoniacDeath/orm.git"
    }
    ],

Install the patch version

composer require doctrine/orm:dev-issue-11199 -W

Run the application test to make sure patch does not break anything else.

[mpdude]

Fixed by #11200