Docs: Removing type: 'integer' from mappings
#10368
Merged
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet another micro-PR ;-) - as requested at doctrine#10364 (comment) I also changed `$currentPrice` from `float` to `int`, since IMO it's better to store prices as `int` (=cents). Question: Is there a reason why most typehints are `int|null`, instead of `?int`? Should I change them?
SenseException
approved these changes
Jan 3, 2023
|
Thank you @ThomasLandauer
It's part of the coding-standard, but as far as I know there's no deeper meaning into this decision. It was introduced in doctrine/coding-standard#266 |
ThomasLandauer
added a commit
to ThomasLandauer/orm
that referenced
this pull request
Jan 3, 2023
Answer to doctrine#10368 (comment) PSR-12 https://www.php-fig.org/psr/psr-12/ has this example, so it looks like it's preferring `?string`: ```php public function functionName(?string $arg1, ?int &$arg2): ?string ``` But changing it in `ruleset.xml` would lead to errors allover the Doctrine code itself, right?
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 9, 2023
* 2.14.x: PHPStan 1.9.8, Psalm 5.4.0 (doctrine#10382) fix typo for missing a comma (doctrine#10377) Docs: Removing `type: 'integer'` from mappings (doctrine#10368) Docs: Moving *attributes* mapping to first position (doctrine#10364) Docs: Deleting duplicate mapping example (doctrine#10363)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 9, 2023
* 2.15.x: Use more precise types for class strings (doctrine#10381) PHPStan 1.9.8, Psalm 5.4.0 (doctrine#10382) fix typo for missing a comma (doctrine#10377) Docs: Removing `type: 'integer'` from mappings (doctrine#10368) Docs: Moving *attributes* mapping to first position (doctrine#10364) Docs: Deleting duplicate mapping example (doctrine#10363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another micro-PR ;-) - as requested at #10364 (comment)
I also changed
$currentPricefromfloattoint, since IMO it's better to store prices asint(=cents).Question: Is there a reason why most typehints are
int|null, instead of?int? Should I change them?