Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Duplicate private fields not detected #10450

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/GH10450Test.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\ORM\Mapping as ORM;
use Doctrine\ORM\Mapping\MappingException;
use Doctrine\Tests\OrmTestCase;
use Generator;

class GH10450Test extends OrmTestCase
{
/**
* @param class-string $className
*
* @dataProvider classesThatOverrideFieldNames
*/
public function testDuplicatePrivateFieldsShallBeRejected(string $className): void
{
$em = $this->getTestEntityManager();

$this->expectException(MappingException::class);

$em->getClassMetadata($className);
}

public function classesThatOverrideFieldNames(): Generator
{
yield 'Entity class that redeclares a private field inherited from a base entity' => [GH10450EntityChild::class];
yield 'Entity class that redeclares a private field inherited from a mapped superclass' => [GH10450MappedSuperclassChild::class];
}
}

/**
* @ORM\Entity
* @ORM\InheritanceType("JOINED")
* @ORM\DiscriminatorMap({ "base": "GH10450BaseEntity", "child": "GH10450EntityChild" })
* @ORM\DiscriminatorColumn(name="type")
*/
class GH10450BaseEntity
{
/**
* @ORM\Column(type="integer")
* @ORM\Id
* @ORM\GeneratedValue
*
* @var int
*/
private $id;

/**
* @ORM\Column(type="text", name="base")
*
* @var string
*/
private $field;
}

/**
* @ORM\Entity
*/
class GH10450EntityChild extends GH10450BaseEntity
{
/**
* @ORM\Column(type="text", name="child")
*
* @var string
*/
private $field;
}

/**
* @ORM\MappedSuperclass
*/
class GH10450BaseMappedSuperclass
{
/**
* @ORM\Column(type="integer")
* @ORM\Id
* @ORM\GeneratedValue
*
* @var int
*/
private $id;

/**
* @ORM\Column(type="text", name="base")
*
* @var string
*/
private $field;
}

/**
* @ORM\Entity
*/
class GH10450MappedSuperclassChild extends GH10450BaseMappedSuperclass
{
/**
* @ORM\Column(type="text", name="child")
*
* @var string
*/
private $field;
}