Removing an entity that is contained in a m2m association fails when flush() is called twice
#10485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpdude
changed the title
flush() is called twice
|
Can anyone advise what would be the expected state of the collection after the UoW removed the entity from it? |
mpdude
force-pushed
the
test-for-10483
branch
from
6dc2420 to
efe8d49
Compare
…`flush()` is called twice Here is a failing test for doctrine#10483. When an entity is removed that is part of a many-to-many collection, that collection will be updated during the `flush()` operation to no longer contain the entity. However, afterwards the collection will be in a dirty state and the internal snapshot still contains the removed entity. That causes the collection to be processed again when `flush()` is called another time. This time, the ORM assumes the entity has been removed from the collection. It will try to build a `DELETE` operation but fails since the entity (from the snapshot) is no longer in the identity map.
mpdude
force-pushed
the
test-for-10483
branch
from
efe8d49 to
a3ea953
Compare
This was referenced Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a failing test for #10483.
When an entity is removed that is part of a many-to-many collection, that collection will be updated during the
flush()operation to no longer contain the entity.However, afterwards the collection will be in a dirty state and the internal snapshot still contains the removed entity.
That causes the collection to be processed again when
flush()is called another time. This time, the ORM assumes the entity has been removed from the collection. It will try to build aDELETEoperation but fails since the entity (from the snapshot) is no longer in the identity map.The error message is
Doctrine\ORM\EntityNotFoundException: Unable to find "..." entity identifier associated with the UnitOfWork.