Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make data providers static #10544

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Make data providers static #10544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/Doctrine/Tests/ORM/Tools/Pagination/RootTypeWalkerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ public function testResolveTypeMapping(string $dqlQuery, string $expectedType):
self::assertSame($expectedType, $query->getSQL());
}

/** @return iterable<array{string, string}> */
public function exampleQueries(): Generator
/** @return Generator<string, array{string, string}> */
public static function exampleQueries(): Generator
{
yield 'Entity with #Id column of special type' => [
'SELECT e.id4 FROM ' . AuxiliaryEntity::class . ' e',
Expand Down
2 changes: 1 addition & 1 deletion tests/Doctrine/Tests/ORM/Tools/Pagination/WhereInWalkerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function testDqlQueryTransformation(string $dql, string $expectedSql): vo
self::assertEquals([0], $result->getSqlParameterPositions(WhereInWalker::PAGINATOR_ID_ALIAS));
}

public function exampleQueries(): Generator
public static function exampleQueries(): Generator
{
yield 'no WHERE condition' => [
'SELECT u, g FROM Doctrine\Tests\ORM\Tools\Pagination\User u JOIN u.groups g',
Expand Down