Remove duplicate array shape #10602
Merged
Remove duplicate array shape #10602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscriminatorColumnMapping is just a specialization of the array shape that is right of the pipe: it has the same fields, except fewer fields are nullable. The union of that is the same thing as the array shape.
SenseException
approved these changes
Mar 29, 2023
|
If you mean before I force-pushed, there were, because I wrongly thought the right thing was to eliminate the right-hand side of the pipe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscriminatorColumnMappingis just a specialization of the array shapethat is right of the pipe: it has the same fields, except fewer fields
are nullable. The union of that is the same thing as the array shape.