Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Finish incomplete definition of class UTCDateTimeType #7727

Merged
merged 1 commit into from
Oct 2, 2019
Merged

[doc] Finish incomplete definition of class UTCDateTimeType #7727

merged 1 commit into from
Oct 2, 2019

Conversation

madand
Copy link
Contributor

@madand madand commented May 31, 2019

Method convertToDatabaseValue() invokes method self::getUtc(), but no actual definition of that method were present. On the other hand, method convertToPHPValue() contained the code that should have been inside of the missing self::getUtc(). This commit fixes the issue.

@madand
Copy link
Contributor Author

madand commented May 31, 2019

I noticed that PR applies to the branch 2.6. Please let me know whether I should also create PR for master.

greg0ire
greg0ire previously approved these changes May 31, 2019
SenseException
SenseException previously approved these changes Jun 2, 2019
@lcobucci lcobucci dismissed stale reviews from SenseException and greg0ire via 766eb69 October 2, 2019 01:57
@lcobucci lcobucci self-assigned this Oct 2, 2019
@lcobucci lcobucci added this to the 2.6.5 milestone Oct 2, 2019
@lcobucci lcobucci merged commit c41fdbc into doctrine:2.6 Oct 2, 2019
@lcobucci
Copy link
Member

lcobucci commented Oct 2, 2019

@madand thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants