Update session examples in docs #8795
Merged
+51
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jun 27, 2021
| Working with scalars | ||
| ~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| In simpler applications there is no need to work with objects in sessions and can use |
There was a problem hiding this comment.
"and you can use"? "and one can use"?
The session examples contained approaches that aren't favorable for an application and needed an overhaul using either scalar values or an DTO instead of the whole entity with detach() and merge().
greg0ire
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #8766 the session-section in the docs needed an update that discourages the usage of an entity in the session just as not using the methods
detach()andmerge(). Because users tend to copy-paste code, I struggled a bit with simple low-line examples and tried to keep them small.