Don't pass null as parameter #8896
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
commented
Aug 7, 2021
| @@ -511,7 +511,7 @@ public function syntaxError($expected = '', $token = null) | |||
| $message .= $expected !== '' ? sprintf('Expected %s, got ', $expected) : 'Unexpected '; | |||
| $message .= $this->lexer->lookahead === null ? 'end of string.' : sprintf("'%s'", $token['value']); | |||
|
|
|||
| throw QueryException::syntaxError($message, QueryException::dqlError($this->query->getDQL())); | |||
| throw QueryException::syntaxError($message, QueryException::dqlError($this->query->getDQL() ?? '')); | |||
There was a problem hiding this comment.
💡 $message of Exception::__construct() must not be null.
derrabus
commented
Aug 7, 2021
| @@ -528,7 +528,7 @@ public function syntaxError($expected = '', $token = null) | |||
| public function semanticalError($message = '', $token = null) | |||
| { | |||
| if ($token === null) { | |||
| $token = $this->lexer->lookahead ?? ['position' => null]; | |||
| $token = $this->lexer->lookahead ?? ['position' => 0]; | |||
There was a problem hiding this comment.
💡 $token['position'] is later used as $offset for substr().
greg0ire
approved these changes
Aug 8, 2021
SenseException
approved these changes
Aug 8, 2021
|
Thanks @derrabus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
nullto various core functions triggers a deprecation warning in PHP 8.1. This PR attempts to fix this kind of error.