Drop more usages of SimpleAnnotationReader #8952
Merged
+68
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
ditch-simple-annotation-reader-2
branch
2 times, most recently
from
f6c2dab to
2a97477
Compare
greg0ire
force-pushed
the
ditch-simple-annotation-reader-2
branch
from
2a97477 to
760abfc
Compare
derrabus
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #8844
When merging up 2.9.5, I was expecting phpunit failures because of new test classes that were not using use statements. The failures did not happen, because #8844 only removed some usages of the
SimpleAnnotationReader, not all.