Restore functional cache tests #8981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/restore-functional-cache-tests
branch
3 times, most recently
from
a2a13b7 to
16b0b85
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
force-pushed
the
improvement/restore-functional-cache-tests
branch
from
16b0b85 to
2cb124c
Compare
SenseException
approved these changes
Sep 6, 2021
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 8, 2021
* 2.9.x: Restore functional cache tests (doctrine#8981) Fix English in `note`. (doctrine#8987) Remove detach deprecation entry in UPGRADE.md (doctrine#8978) Bump to PHPStan 0.12.98 and Psalm 4.10.0 (doctrine#8979)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 8, 2021
* 2.9.x: Restore functional cache tests (doctrine#8981) Fix English in `note`. (doctrine#8987) Remove detach deprecation entry in UPGRADE.md (doctrine#8978) Bump to PHPStan 0.12.98 and Psalm 4.10.0 (doctrine#8979) Signed-off-by: Alexander M. Turek <me@derrabus.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support for Doctrine cache 2, many functional tests that involve caching have been disabled. This PR enables them again, using a wrapped
ArrayAdapterinstead ofArrayCache.I'm targeting 2.9.x here because I'm only changing tests and not touching any production code.