Fix docblock types for some nullable properties #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
nullable
branch
4 times, most recently
from
842c8ca to
d890c69
Compare
phansys
force-pushed
the
nullable
branch
6 times, most recently
from
c0838c2 to
03f7785
Compare
derrabus
reviewed
Sep 21, 2021
derrabus
reviewed
Sep 21, 2021
derrabus
reviewed
Sep 21, 2021
derrabus
approved these changes
Sep 22, 2021
SenseException
approved these changes
Sep 22, 2021
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 29, 2021
* 2.9.x: Minor rewording (doctrine#8435) Don't presume one-to-one lookup returned an entity (doctrine#9028) Minor change about double The (doctrine#9038) Remove duplicate comment (doctrine#9036) Fix docblock types for some nullable properties (doctrine#9024) Explicitly allow to use `Comparison` and `Composite` in JOIN conditions (doctrine#9022) Fix some typehints in QueryBuilder Bump PHPStan (doctrine#9014) Add tests for advanced types in collection matching Use types in collection persister Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 29, 2021
* 2.9.x: Minor rewording (doctrine#8435) Don't presume one-to-one lookup returned an entity (doctrine#9028) Minor change about double The (doctrine#9038) Remove duplicate comment (doctrine#9036) Fix docblock types for some nullable properties (doctrine#9024) Explicitly allow to use `Comparison` and `Composite` in JOIN conditions (doctrine#9022) Fix some typehints in QueryBuilder Bump PHPStan (doctrine#9014) Add tests for advanced types in collection matching Use types in collection persister Signed-off-by: Alexander M. Turek <me@derrabus.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9022 (comment).