Add XSD "orm:columntoken" type in order to support reserved words in column names

[phansys]

I don't know if this is the proper way to support backticks in the column definition from the XML perspective, but currently if they are used, the schema validation fails (see this sample action):

element field: Schemas validity error : Element '{http://doctrine-project.org/schemas/orm/doctrine-mapping}field', attribute 'column': '`count`' is not a valid value of the atomic type 'xs:NMTOKEN'.

See Quoting Reserved Words.

[wickedOne]

have you considered making a custom simple type which just adds backticks to the pattern of NMTOKEN and use that as type for column definitions?

xs:string also allows tabs, carriage returns, etc which you don't want in your column names...

possible implementation would be:

<xs:simpleType name="columntoken" id="columntoken">
  <xs:restriction base="xs:token">
    <xs:pattern value="[-._:A-Za-z0-9`]+" id="columntoken.pattern">
    </xs:pattern>
  </xs:restriction>
</xs:simpleType>

[phansys]

Thank you so much for your help @wickedOne.
I've changed the type as suggested.

[phansys]

Since the support for the backticks in the column name definition were already supported and the issue is present only in the schema validation, I think this is a bugfix instead of improvement.

[wickedOne]

nitpicking here, but the xsd didn't "support" backticks, the xsd simply isn't enforced (i.e. doctrine doesn't stop processing your mapping because it doesn't validate against the xsd). so "improvement" seems about right to me as it didn't stop you from using this library without this adjustment

[phansys]

it didn't stop you from using this library without this adjustment

In my case, this situation is preventing my private builds to pass, since I started to check my schema against the XSD definition.
Obviously, my app was working regardless this problem.

[greg0ire]

Thanks @phansys! Kind of on the fence regarding the label