Fix EnumType not being hydrated with HYDRATE_ARRAY #9995
Merged
+112
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remedge
previously approved these changes
Aug 16, 2022
|
Sorry for picking up your PR that late. Can you please rebase your PR on 2.13.x? If I do so locally, I get a couple of test failures that seem to be related to your changes. |
kvush
force-pushed
the
fix_EnumType_with_HYDRATE_ARRAY_returns_string
branch
from
53e488e to
ed691e1
Compare
|
Thanks @derrabus, it was my new enum field in CmsUser that broke bunch of existing tests. So I decides do not touch CmsUser and cover my test cases with another Entity. Now all looks good. |
added 2 commits
August 31, 2022 15:16
|
@derrabus is there anything else that needs to be improved please? |
derrabus
approved these changes
Sep 14, 2022
derrabus
changed the title
|
Thank you! |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 21, 2022
* 2.14.x: PHPStan 1.8.5, Psalm 4.27.0 (doctrine#10033) Fix EnumType not being hydrated with HYDRATE_ARRAY (doctrine#9995) "Strange" return lines in documentation of inheritance-mapping.rst (doctrine#10027) More strange break lines in inheritance-mapping.rst (doctrine#10028)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 22, 2022
* 2.14.x: PHPStan 1.8.5, Psalm 4.27.0 (doctrine#10033) Fix EnumType not being hydrated with HYDRATE_ARRAY (doctrine#9995) "Strange" return lines in documentation of inheritance-mapping.rst (doctrine#10027) More strange break lines in inheritance-mapping.rst (doctrine#10028) Add phpdoc for discriminatorColumn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9947
add new processEnum method in ArrayHydrator