Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crossbow issues #108

Merged
merged 17 commits into from
Jul 15, 2022
Merged

Fix crossbow issues #108

merged 17 commits into from
Jul 15, 2022

Conversation

Heezay
Copy link
Contributor

@Heezay Heezay commented Jul 14, 2022 •
edited
Loading

Objective

  1. Resolve a problem with dylib wrong build paths.
  2. Fix issues with the difference between Android Studio cmdline tools install path and crossbundle install cmdline tools install path.
  3. Make gradle project installation by default.

Solution

  1. Separate build path to escape issues with apk building
  2. Refactor code in sdkmanager.rs for correct cmdline tools access.
  3. Refactor android.rs to change CLI commands and make gradle projects built by default. Add --apk flag to build native APK files.

Changelog

  1. Now libs have one common directory to build. Was added additional directories for .apk and .aab files to avoid confusion about file ownership.
  2. Refactored code for sdkmanager.rs to escape bugs.
  3. Changed CLI commands to make gradle project building by default. For native apk building added --apk flag.

@Heezay Heezay self-assigned this Jul 14, 2022
@Heezay Heezay marked this pull request as draft July 14, 2022 11:37
@Heezay Heezay requested a review from enfipy July 15, 2022 11:43
@enfipy enfipy marked this pull request as ready for review July 15, 2022 12:21
enfipy
enfipy previously approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@enfipy enfipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enfipy enfipy merged commit 92b7904 into main Jul 15, 2022
@enfipy enfipy deleted the dylibs-build-path branch July 15, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enfipy enfipy enfipy left review comments

Assignees

@Heezay Heezay

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Heezay @enfipy