InputCommon/DolphinQt: Mapping related race fixes and cleanups. #8643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
mapping-race-fix
branch
from
0bbf993 to
03d36df
Compare
BhaaLseN
reviewed
Feb 23, 2020
…ate lock" is held on redraw.
…trast in some dark themes.
jordan-woyak
force-pushed
the
mapping-race-fix
branch
from
03ca7eb to
6b109bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate racy
UpdateInputcall withinDetectInput.(HotkeyManager/Core will already be doing this)
Split separate mapping indicator types into their own classes.
The "Point" indicator now uses the entire bounding box for drawing the "red dot".
The reduced box seemed to confuse some people into thinking it needed some kind of calibration.
Ensure the "state lock" is held when updating indicators.
Previously it was not held on a redraw invoked from Qt.
Cleaned up indicator code to eliminate some redundant logic and scalar multiplication all over the place.
Minor change to indicator colors for better contrast on some dark themes.
